Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT1] migrate from prettier+eslint to biome #872

Closed
wants to merge 33 commits into from
Closed

[DRAFT1] migrate from prettier+eslint to biome #872

wants to merge 33 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 6, 2024

Issue

N/A

Description

Migrates from prettier+eslint to biomejs

Testing

CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c5d112d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security Socket Security
Copy link

socket-security bot commented Jun 6, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@biomejs/[email protected] shell 0 151 kB dominionl
npm/@biomejs/[email protected] None 0 20.5 MB dominionl
npm/@biomejs/[email protected] None 0 22.1 MB dominionl
npm/@biomejs/[email protected] None 0 19.4 MB dominionl
npm/@biomejs/[email protected] None 0 21.9 MB dominionl
npm/@biomejs/[email protected] None 0 24.1 MB dominionl
npm/@biomejs/[email protected] None 0 24.9 MB dominionl
npm/@biomejs/[email protected] None 0 23.5 MB dominionl
npm/@biomejs/[email protected] None 0 28 MB dominionl
npm/[email protected] None 0 7.68 MB mrexox
npm/[email protected] None 0 7.95 MB mrexox
npm/[email protected] None 0 7.54 MB mrexox
npm/[email protected] None 0 7.77 MB mrexox
npm/[email protected] None 0 7.54 MB mrexox
npm/[email protected] None 0 7.77 MB mrexox
npm/[email protected] None 0 7.7 MB mrexox
npm/[email protected] None 0 8.13 MB mrexox
npm/[email protected] None 0 0 B

🚮 Removed packages: npm/@eslint-community/[email protected], npm/@eslint-community/[email protected], npm/@eslint/[email protected], npm/@eslint/[email protected], npm/@humanwhocodes/[email protected], npm/@humanwhocodes/[email protected], npm/@humanwhocodes/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@ungap/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Jun 6, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/@biomejs/[email protected]
  • Install script: postinstall
  • Source: node scripts/postinstall.js
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node ./postinstall.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

trivikr added 25 commits June 5, 2024 18:31
@trivikr
chore: remove biome default config
842df05
@trivikr
chore: yarn biome migrate prettier
0b94cf2
@trivikr
chore: use default biome formatter config for semicolons
efed5d1
@trivikr
chore: use default biome formatter config for quoteStyle
e0dce10
@trivikr
fix: biome config for formatter.ignore
18182ac
@trivikr
chore: set biome files.maxSize as 5 MB
6910ecc
@trivikr
chore: remove redundant biome formatter settings
463e826
@trivikr
chore(deps-dev): remove prettier
bfeadc4
@trivikr
chore: use biome in VSCode settings
df3ffdc
@trivikr
chore: yarn biome migrate eslint --write
a87beca
@trivikr
chore: biome format package.json
50bc335
@trivikr
chore: move biome formatter.ignore to files.ignore
eec239e
@trivikr
chore: update eslint-ignore with biome-ignore
662e7d2
@trivikr
chore: remove @typescript-eslint/ban-ts-comment
f5c5104
@trivikr
chore: remove eslint no-fallthrough
27c77fc
@trivikr
chore: biome disable lint/style/useImportType
f39f9a8
@trivikr
chore: biome disable lint/style/useNodejsImportProtocol
8677e6d
@trivikr
chore: biome disable lint/complexity/noForEach
3d1cef4
@trivikr
chore: biome disable lint/complexity/useFlatMap
d73b789
@trivikr
chore: biome disable lint/style/noUnusedTemplateLiteral
cf9f8d7
@trivikr
chore: biome disable lint/style/useTemplate
546b9d4
@trivikr
chore: biome disable lint/complexity/useOptionalChain
7d43937
@trivikr
chore: biome disable lint/performance/noAccumulatingSpread
83f49e2
@trivikr
chore: use arrow fn in getJsCodeshiftParser callback
5bc1c19
@trivikr
chore: biome-ignore in cli
9f45082
@trivikr trivikr mentioned this pull request Jul 10, 2024
Merged
@trivikr trivikr changed the title chore(deps-dev): migrate from prettier+eslint to biome [DRAFT1] migrate from prettier+eslint to biome Jul 10, 2024
@trivikr
Copy link
Member Author

trivikr commented Jul 10, 2024

Replaced by #886

@trivikr trivikr closed this Jul 10, 2024
@trivikr trivikr deleted the biome branch July 10, 2024 21:40
@github-actions GitHub Actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trivikr